Comiler fixes #19953
Closed
Comiler fixes #19953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `listLazyRoute` would store invalid information in a compiler internal cache, which lead to incorrect paths that were used during emit. This commit fixes this.
This prevents errors reported against `.ngfactory.ts` files show up as the result of running `ngc`. Closes angular#19935
3 tasks
|
You can preview ae24430 at https://pr19953-ae24430.ngbuilds.io/. |
chuckjaz
approved these changes
Oct 26, 2017
tbosch
added
area: core
chuckjaz
approved these changes
Oct 26, 2017
| @@ -214,6 +214,8 @@ export function performWatchCompilation(host: PerformWatchHost): | |||
| host.reportDiagnostics( | |||
| [createMessageDiagnostic('Compilation complete. Watching for file changes.')]); | |||
| } else { | |||
| // clear out the cachedProgram as we can only use it as the `oldProgram` 1x. | |||
| cachedProgram = undefined; | |||
There was a problem hiding this comment.
save the a local copy of this and set it to undefined before calling performCompilation
This also changes the compiler so that we throw less often on structural changes and produce a meaningful state in the `ng.Program` in case of errors. Related to angular#19951
tbosch
force-pushed
the
fix_multiimport
branch
from
b778358
to
67b2ce6
Compare
|
You can preview b778358 at https://pr19953-b778358.ngbuilds.io/. |
|
You can preview 67b2ce6 at https://pr19953-67b2ce6.ngbuilds.io/. |
matsko
pushed a commit
that referenced
this pull request
Oct 27, 2017
matsko
pushed a commit
that referenced
this pull request
Oct 27, 2017
matsko
pushed a commit
that referenced
this pull request
Oct 27, 2017
matsko
pushed a commit
that referenced
this pull request
Oct 27, 2017
alexeagle
added a commit
to alexeagle/angular
that referenced
this pull request
Oct 30, 2017
…ngular#19953)" This reverts commit 957be96.
3 tasks
alexeagle
added a commit
to alexeagle/angular
that referenced
this pull request
Oct 30, 2017
…ngular#19953)" This reverts commit 957be96. This broke error reporting: instead of a real error message, we just get an error that a non-existing ngfactory.ts file is missing.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.